Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Added support for initWithObjectsAndKeys:

#221

Implemented both dictionaryWithObjectsAndKeys: and initWithObjectsAndKeys: for CPDictionary.

Reported by Farcaller · February 14th, 2009 @ 03:19 AM

State: new
Milestone: none
Assigned to: nobody

Activity

  1. Ross Boucher
    Ross Boucher
    • Tag changed from @to-review, cpdictionary to @working-on, cpdictionary

    The code that re-uses the initWith implementation could be improved. For example, there's no need to loop over the arguments array, I think using Array.prototype.slice.apply(arguments, etc.) is a better approach.

    Also, to class_getInstanceMethod, use the appropriate runtime function for getting the selector, rather than assuming its a string, since that may change.

    Finally, I believe there is also a runtime method for directly getting the impl, rather than calling .method_imp.

    Other than that, it looks good. Perhaps submit to github and send a github commit link next time. Looking forward to the patch.

    March 24th, 2009 @ 11:06 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.