#221 new

Added support for initWithObjectsAndKeys:

Reported by Farcaller | February 14th, 2009 @ 03:19 AM

Implemented both dictionaryWithObjectsAndKeys: and initWithObjectsAndKeys: for CPDictionary.

Comments and changes to this ticket

  • Ross Boucher

    Ross Boucher March 24th, 2009 @ 11:06 PM

    • Tag changed from @to-review, cpdictionary to @working-on, cpdictionary

    The code that re-uses the initWith implementation could be improved. For example, there's no need to loop over the arguments array, I think using Array.prototype.slice.apply(arguments, etc.) is a better approach.

    Also, to class_getInstanceMethod, use the appropriate runtime function for getting the selector, rather than assuming its a string, since that may change.

    Finally, I believe there is also a runtime method for directly getting the impl, rather than calling .method_imp.

    Other than that, it looks good. Perhaps submit to github and send a github commit link next time. Looking forward to the patch.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

The Cappuccino Web Framework, including AppKit, Foundation, and Objective-J.

Shared Ticket Bins

People watching this ticket