class_addMethod parameter name
Reported by Kelvin Sherlock | 2008-09-17 05:05:33 UTC
The parameter list uses "types", the code uses "aType". One of them needs to change.
function class_addMethod(/Class/ aClass, /SEL/ aName, /IMP/ anImplementation, /String/types) {
if (aClass.method_hash[aName])
return NO;
var method = new objj_method(aName, anImplementation, aType);
aClass.method_list.push(method);
aClass.method_dtable[aName] = method;
// FIXME: Should this be done here?
// If this is a root class...
if (!ISMETA(aClass) && GETMETA(aClass).isa == GETMETA(aClass))
class_addMethods(GETMETA(aClass), methods);
return YES;
}
Comments and changes to this ticket
-
Tom Robinson 2008-09-17 13:34:56 UTC
You're right, but this function never appears to be called. Do we need it?
-
Francisco Tolmasky 2008-09-17 15:47:22 UTC
Yes we need it. Doesn't cause a bug yet because we don't have any type info stuff turned on/implemented.
-
Ross Boucher 2008-09-17 15:49:21 UTC
- Assigned user set to “Ross Boucher”
- State changed from “new” to “resolved”
Fixed in commit 088fdf4..a64d1a1
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
The Cappuccino Web Framework, including AppKit, Foundation, and Objective-J.
Francisco Tolmasky
Kelvin Sherlock
Ross Boucher