Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

class_addMethod parameter name

#44

The parameter list uses "types", the code uses "aType". One of them needs to change.

function class_addMethod(/Class/ aClass, /SEL/ aName, /IMP/ anImplementation, /String/types) {

if (aClass.method_hash[aName])
    return NO;

var method = new objj_method(aName, anImplementation, aType);

aClass.method_list.push(method);
aClass.method_dtable[aName] = method;

// FIXME: Should this be done here?
// If this is a root class...
if (!ISMETA(aClass) && GETMETA(aClass).isa == GETMETA(aClass))
    class_addMethods(GETMETA(aClass), methods);

return YES;

}

Reported by Kelvin Sherlock · September 17th, 2008 @ 05:05 AM

State: resolved
Milestone: none
Assigned to: Ross Boucher Ross Boucher

Activity

  1. Tom Robinson
    Tom Robinson

    You're right, but this function never appears to be called. Do we need it?

    September 17th, 2008 @ 01:34 PM

  2. Francisco Tolmasky
    Francisco Tolmasky

    Yes we need it. Doesn't cause a bug yet because we don't have any type info stuff turned on/implemented.

    September 17th, 2008 @ 03:47 PM

  3. Ross Boucher
    Ross Boucher
    • Assigned user set to Ross Boucher
    • State changed from new to resolved

    Fixed in commit 088fdf4..a64d1a1

    September 17th, 2008 @ 03:49 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.