[CPMenu menuBarHeight] should be + not -
Reported by nciagra | December 24th, 2008 @ 09:08 AM | in 0.6.5
Line 174 of CPMenu.j:
-(float)menuBarHeight
However all other menu bar methods are +, so they can be accessed with [CPMenu menuBarSomething], instead of [[CPApp mainMenu] menuBarHeight]. If it is changed to plus, the method needs to be changed to:
{ if([CPApp mainMenu]) return MENUBAR_HEIGHT;
return 0.0; }
Also, line 204 of CPDOMWindowBridge.j does the following:
if([CPMenu menuBarVisible]) var menuBarHeight = [[CPApp mainMenu] menuBarHeight];
This would need to be updated to:
if([CPMenu menuBarVisible]) var menuBarHeight = [CPMenu menuBarHeight];
Of course, there could be a reason for menuBarHeight being an instance function, in which case please let me know!
Comments and changes to this ticket
-
Francisco Tolmasky December 29th, 2008 @ 03:37 PM
I'm not really sure why this is to tell you the truth, we simply modeled it after Cocoa's behavior: http://developer.apple.com/docum...//apple_ref/occ/instm/NSMenu/menuBarHeight
We could also just add + menuBarHeight and have both
-
-
Francisco Tolmasky January 4th, 2009 @ 02:30 PM
- Milestone set to “0.6.5”
- State changed from “new” to “resolved”
Fixed by nciarga
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
The Cappuccino Web Framework, including AppKit, Foundation, and Objective-J.
nciagra