Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

CPFlashView <embed> and <object>

#150

Currently, CPFlashView orders its elements as the following:

DOMElement.appendChild(DOMObjectElement); DOMElement.appendChild(DOMEmbedElement);

The comment above these lines indicates that this is to maintain compatibility with IE. However, Ross and I agree that this seems incorrect. I'm not sure what the proper way to deal with IE is, but I have personally always seen the embed as a child of the object, not a sibling:

DOMElement.appendChild(DOMObjectElement); DOMObjectElement.appendChild(DOMEmbedElement);

Reported by nciagra · November 25th, 2008 @ 10:40 AM

State: new
Milestone: 0.6.5
Assigned to: Francisco Tolmasky Francisco Tolmasky

Activity

  1. Francisco Tolmasky
    Francisco Tolmasky
    • Assigned user set to Francisco Tolmasky
    • Tag changed from appkit to appkit, cpflashview
    • Milestone set to 0.6.5

    December 11th, 2008 @ 11:03 PM

  2. ronin-756 (at lighthouseapp)
    ronin-756 (at lighthouseapp)

    I've started some tests on this ticket. Here are the results of my tests :

    The flash is correctly displayed in IE7 with the elements ordered as follow : DOMElement.appendChild(DOMEmbedElement); DOMElement.appendChild(DOMObjectElement);

    I agree that the embed tag should be a child of the object tag. Interesting infos can be found here here : http://www.alistapart.com/articl...

    So I tried to order the elements like this : DOMElement.appendChild(DOMObjectElement); DOMObjectElement.appendChild(DOMEmbedElement);

    But IE7 returns the following error : Invalid argument line 572 Char 5, which corresponds to this line : DOMObjectElement.appendChild(DOMEmbedElement);

    What do you guys think about it? What should we do?

    January 18th, 2009 @ 02:35 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.