Changeset [e3d0d6991855008c124af913d5d4f98d24110968] by Alexander Ljungberg

August 14th, 2012 @ 11:43 AM

Refs #1364. Avoid repeated makeFirstResponder: calls within sheet parent.

If a window contained a text field which was the initial first responder, and the window was displaying a sheet, clicking on the window would cause the text field to alternate between being the first responder and not.

This was caused by the window orderFront: setting its first responder to the initial responder if there wasn't any responder yet. This would cause the text field to focus, even that the window wasn't the key window, and then on the next click the text field would blur which would make the text field automatically resign its first responder status.

The solution is to leave the first responder status alone if a window which isn't the key window is orderFront:ed. This appears to be more sensible UX in general. You don't expect the first responder of non-key windows to change when you click it's background.
https://github.com/cappuccino/cappuccino/commit/e3d0d6991855008c124...

Committed by Alexander Ljungberg

  • M AppKit/CPWindow/CPWindow.j
New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

The Cappuccino Web Framework, including AppKit, Foundation, and Objective-J.

Shared Ticket Bins